itamarst / eliot

Eliot: the logging system that tells you *why* it happened
https://eliot.readthedocs.io
Apache License 2.0
1.1k stars 66 forks source link

Support for PyInstaller #390

Closed itamarst closed 5 years ago

itamarst commented 5 years ago

Fixes #386.

itamarst commented 5 years ago

@crwood could you try this?

crwood commented 5 years ago

@itamarst My apologies for missing this earlier..

If it matters, I have since tested a non-trivial (python2) application running under a frozen/PyInstaller interpreter on Linux, macOS, and Windows and can confirm that, in all three cases, with these changes in place, eliot logging is now working as expected.

Thank you very much for this -- and for eliot more generally! I'm greatly looking forward to using it in future projects. :)

itamarst commented 5 years ago

No problem, Jean-Paul conveyed that it worked. Thanks for the further checks!