Open exarkun opened 4 years ago
Hm. Will take a look.
Are you running that on Python 3 too? If so, does it fail there?
Alas, I'm only running on Python 2 on CI.
Since I've never seen that on recent runs (Python 3.5+), I hypothesize it's something about dictionary order stability, but would need to read actual code to be sure.
It looks like another test fails similarly:
======================================================================
FAIL: test_logCallsDefaultLoggerWrite (eliot.tests.test_validation.MessageTypeTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/nix-build-python2.7-eliot-1.7.0.drv-0/eliot-1.7.0/eliot/tests/test_validation.py", line 533, in test_logCallsDefaultLoggerWrite
self.assertEqual(messages[0][u"key"], 1234)
AssertionError: 5 != 1234
Here's another one :/
ERROR: test_global_cleanup (eliot.tests.test_testing.CaptureLoggingTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/nix-build-python2.7-eliot-1.7.0.drv-0/eliot-1.7.0/eliot/tests/test_testing.py", line 662, in test_global_cleanup
self.assertEqual(messages[0][u"some_key"], 1234)
KeyError: u'some_key'
every time I mark another one as skipped, another pops up.
Seen on my CI:
This is a somewhat older version so perhaps the problem has been fixed already. I couldn't find any tickets that seemed related, though.