search

itavero / AMNL-Mollie

PHP 5.3+ library for communicating with Mollie (PSP).
http://itavero.github.io/AMNL-Mollie
MIT License
4 stars 1 forks source link

Browser-object in AMNL\Mollie\Client #12

Open itavero opened 11 years ago

itavero commented 11 years ago

I think we don't need the \Buzz\Browser property in the AMNL\Mollie\Client class. In my opinion it would be better if the Client class implements the needed logic for calling the Buzz\Client\ClientInterface object.

itavero commented 11 years ago

Do you have an opinion regarding this issue, @ruudk?

ruudk commented 11 years ago

Why do you want to change it? What's the problem? :)

itavero commented 11 years ago

It's not really a problem. But in my opinion the logic used from the Browser class is minimal. Removing it and implementing the minimal code directly in the PaymentGateways removes some overhead, makes the libraries more decoupled and might even improve the performance (in terms of time and memory) by a very small fraction. :P

itavero commented 11 years ago

In other words: the current situation just doesn't feel quite right to me. ;)

ruudk commented 11 years ago

Then change it ;)

But keep in mind backwards compatibility if possible.

itavero commented 11 years ago

I don't expect any BC breaks, cause the Browser object was never exposed. I'll try to change this next weekend. After that I think it's time for the first stable release. ;)

ruudk commented 11 years ago

Great, Maybe you should contact Mollie to get this lib listed on their page :)

itavero commented 11 years ago

I have contacted them before and one of their developers did look at the library I believe, but I have not heard anything from them since then.