itavero / AMNL-Mollie

PHP 5.3+ library for communicating with Mollie (PSP).
http://itavero.github.io/AMNL-Mollie
MIT License
4 stars 1 forks source link

Add valid PHPDoc #16

Closed ruudk closed 7 years ago

ruudk commented 11 years ago

For instance

    /**
     * Returns an array of Bank-instances the customer can choose from.
     *
     * @param boolean $use_cache Use internal array cache?
     * @return array An array containing Bank-instances
     */
    public function getBankList($use_cache = true)

Should be

    /**
     * Returns an array of Bank-instances the customer can choose from.
     *
     * @param boolean $use_cache Use internal array cache?
     * @return \AMNL\Mollie\IDeal\Bank[]
     */
    public function getBankList($use_cache = true)

That way, an IDE like PHPStorm, can do better autocompletion.

itavero commented 11 years ago

As far as I know the IDE I use does not use this, so that's probably why I've typed array instead. Please let me know if there are more PHPDoc issues like this. I'll try to look over the PHPDoc soon.

ruudk commented 11 years ago

You should test it out in PHPStorm (great IDE for Mac).

ruudk commented 11 years ago

Partially fixed by #18