search

itay-grudev / SingleApplication

Replacement of QtSingleApplication for Qt 5 and Qt 6 with support for inter-instance communication.
https://itay-grudev.github.io/SingleApplication/
Other
891 stars 215 forks source link

Kill recovery not working #190

Open cajus opened 7 months ago

cajus commented 7 months ago

Hi, just found your lib and started playing with it. One problem I've noticed here is that stopping a simple application via QtCreators "stop" button or pressing Ctrl+c makes the application unstartable with no obvious way to recover. It's always secondary, even though there's no process running anymore.

As the documentation states

Additionally the library can recover from being forcefully killed on *nix systems and will reset the memory block given that there are no other instances running.

, I'm wondering if there's something else needs to be done in main.cpp to make it play happily.

Using master + Qt 6.6.2.

itay-grudev commented 7 months ago

What OS was this on?

cajus commented 7 months ago

Oh. Sorry, forgot that info. Linux. Fedora (Silverblue inside a distrobox) 39.

Update: but it's reproducible without a distrobox - so just take the Fedora 39.

itay-grudev commented 7 months ago

@cajus There are significant problems with QSharedMemory and QSystemSemaphore in Qt 6.6. They changed the implementation for the worse. It may not be possible to mitigate the issue on our side.

I am working on a new implementation that doesn't use QSharedMemory but it's not finished yet.

As a workaround you may try to delete it manually using ipcrm. I'm sorry I can't be more helpful for the time being.

cajus commented 7 months ago

@itay-grudev - ak, ok. Thanks for the info!

cajus commented 7 months ago

Looks like the linphone guys worked around it by extending your code using DBus on linux for the time being: https://github.com/BelledonneCommunications/linphone-desktop/tree/master/linphone-app/src/app/single-application

itay-grudev commented 7 months ago

@cajus That is indeed a clever way for implementing it in Linux, but I can't easily adapt it to Windows.

My WIP implementation right now is using QLocalSockets, where one instance becomes a QLocalServer and becomes the primary. As long as something is listening on that socket - they become a primary and every other instance a secondary.

It looks promising so far, but I'm struggling to find the time to finish it.

hgkamath commented 6 months ago

firstly, many thanks to developer/contributors. It is believed that the down stream bug, https://github.com/dail8859/NotepadNext/issues/514 is related to this.

Some questions to consider. (re-included here from that issue description) Q1) should the app, when run as root user, check to see if the desktop belongs to a user and create the shm-file with ownership of user, or maybe not? Q2) should the app give a different filename to the shm-file per-User-per-Desktop in order to prevent name collision? Q3) should the app give a better error message to inform the user as to how to correct the problem? Q4) should the app delete the shm-file after the last user-process using it exits? Q5) should the shm-file's filename have the string with the app's name in it, in order to clue the user that the file was created by the app.

itay-grudev commented 6 months ago

I'll bump it up in my TODO list and see if I can allocate several hours to finish it.

Ri0n commented 4 months ago

Hi @itay-grudev Maybe you can push your WIP into a branch? So those who have more spare time can propose PRs finishing the feature.

itay-grudev commented 4 months ago

@Ri0n That is the least I can do. I'll crate a draft PR with all of my outstanding changes.

itay-grudev commented 4 months ago

@Ri0n I spent my entire day today hunting down my old code, tidying it up, making sure that it at least compiles. All of my WIP work is in: #192.

The basic functionality works and I've left some implementation notes there. It should be a solid starting point.