search

itaylor / redux-socket.io

An opinionated connector between socket.io and redux
410 stars 53 forks source link

Removing unused dispatch #39

Closed node-gs closed 5 years ago

node-gs commented 5 years ago

Is there a reason why this has been left in?

itaylor commented 5 years ago

Since that defaultExecute function is the reference implementation of an execute function, I left the fourth arg there as a form of documentation that the function gets passed four args, and that the fourth arg is redux dispatch. I agree that it's not used and is therefore unnecessary in that default implementation, but since it makes the code easier to read and understand I think I'll keep it there unless it's causing people problems.