itayrefaely / pe

0 stars 0 forks source link

Adding multiple activities with overlapping date and time should not be allowed. #3

Open itayrefaely opened 11 months ago

itayrefaely commented 11 months ago

Run commands:

  1. add-activity Morning Run duration/01:00:00 distance/10000 datetime/2021-09-01 06:00
  2. add-activity Workout duration/01:00:00 distance/10000 datetime/2021-09-01 06:00

Expected behavior:\ Some error message saying that there is already an activity during this time.

Actual behavior:\ added successfully with success message.

Screenshot 2023-11-17 at 16.41.14.png

nus-se-bot commented 11 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

In activities like triathlons or combined training sessions, users might engage in different types of exercises simultaneously or in quick succession. Allowing multiple activities to be logged at the same time provides the flexibility to accurately record such complex training sessions. For example, it's common for swimmers to swim different styles in one session (switching freestyle, butterfly, etc.). The ability to add activities with the same timestamp supports this variability in exercise routines.

For later versions of the app with potentially more complex workout tracking, the overlap tracking might become a feature worth implementing.

Providing users with the autonomy to decide how they want to log their activities, even if it means having overlapping times, respects their personal preference and allows the user to use the app in different ways. Thus it makes the application more user-friendly and reduce potential sources of frustration or confusion.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your reason]