JasperDiShu commented 1 year ago

Description: When I use the kubectl-neat 2.0.3 to do the clean of yaml file, I found that after neaten the yaml of a svc, the yaml still contains the part of clusterIP and clusterIPs. In the scenario that I generated the yaml file in a svcCIDR range is 172.21.0.0/16 k8s environment, but apply these svc yaml files in a new environment that svcCIDR is 192.168.0.0/16, it will occur the error that 'failed to allocated ip:172.21.132.103 with error:provided IP is not in the valid range. The range of valid IPs is 192.168.0.0/16'.

What I expected to happen: I think these part 'clusterIP and clusterIPs' in the yaml is not the mandatory part, perhaps it could be remove by the kubectl-neat function. Thanks for your time to look at this issue.

Some addition output I can provide: Original svc yaml content:

apiVersion: v1 kind: Service metadata: annotations: meta.helm.sh/release-name: minimum meta.helm.sh/release-namespace: default creationTimestamp: "2022-09-07T02:19:41Z" labels: app: im app.kubernetes.io/managed-by: Helm grp: xxxx managedFields:

apiVersion: v1 fieldsType: FieldsV1 fieldsV1: f:metadata: f:annotations: .: {} f:meta.helm.sh/release-name: {} f:meta.helm.sh/release-namespace: {} f:labels: .: {} f:app: {} f:app.kubernetes.io/managed-by: {} f:grp: {} f:spec: f:ports: .: {} k:{"port":xxx,"protocol":"TCP"}: .: {} f:name: {} f:port: {} f:protocol: {} f:targetPort: {} k:{"port":xxx,"protocol":"TCP"}: .: {} f:name: {} f:port: {} f:protocol: {} f:targetPort: {} f:selector: .: {} f:app: {} f:sessionAffinity: {} f:type: {} manager: Go-http-client operation: Update time: "2022-09-07T02:19:41Z" name: im namespace: default resourceVersion: "4366696" uid: 8cf3fb18-6703-4e98-91f9-379f1abb0b50 spec: clusterIP: 172.21.132.103 clusterIPs:
172.21.132.103 ipFamilies:
IPv4 ipFamilyPolicy: SingleStack ports:
name: xx port: xxxx ...............

Neat svc yaml content:

apiVersion: v1 kind: Service metadata: annotations: meta.helm.sh/release-name: minimum meta.helm.sh/release-namespace: default labels: app: im app.kubernetes.io/managed-by: Helm grp: xxx name: im namespace: default spec: clusterIP: 172.21.132.103 clusterIPs:

172.21.132.103 ipFamilies:
IPv4 ipFamilyPolicy: SingleStack ports:
name: xxx port: xxxx

The error info when I applied the neat yaml in a new env which svcCIDR changed:

The Service "xxx" is invalid: spec.clusterIPs: Invalid value: []string{"172.21.132.103"}: failed to allocated ip:172.21.132.103 with error:provided IP is not in the valid range. The range of valid IPs is 192.168.0.0/16