itb-community / ITB-ModLoader

A lua-based mod loader for the game Into the Breach
48 stars 17 forks source link

Audit modloader added functions to make sure none are redundant to new built in functions #159

Open KnightMiner opened 2 years ago

KnightMiner commented 2 years ago

Between the 1.2 update and the Advanced Edition update, quite a few new functions have been added to the game. Now would be a good time to go through all the functions the modloader adds to verify two things:

Would be worth doing this to modApiExt afterwards as well.

KnightMiner commented 2 years ago

Some things found at a quick search:

Some things that are not the same

KnightMiner commented 2 years ago

As another note, it looks like we have three skill effect functions that should likely be supported for the extra queued options:

Need to test if all of them work as queued attacks, I highly suspect AddReverseAirstrike will, but not sure on the other two

Lemonymous commented 1 year ago

PR #165 addresses Board:SetShield and Pawn:IsPowered, though I have not looked into Board:IsMutation

KnightMiner commented 1 year ago

No work is needed for Board:IsMutation, that was a comment saying that IsMutation is not the same and does not need to be considered.

71800fe deals with Pawn:IsPowered, since ours was broken and vanilla exists might as well use the vanilla one.