search

itb-community / ITB-ModLoader

A lua-based mod loader for the game Into the Breach
48 stars 17 forks source link

Remove SpaceDamage metadata #203

Closed Lemonymous closed 1 year ago

Lemonymous commented 1 year ago

The data that was previously available via SpaceDamage:GetMetadata() is now available via new functions added to SpaceDamage objects when memedit is enabled:

SpaceDamage

Lemonymous commented 1 year ago

Addresses #197 and #198

KnightMiner commented 1 year ago

Just to be clear, did we decide on removing these functions instead of having them return false/empty table? If so, looks fine to me.

Lemonymous commented 1 year ago

I didn't feel we got 100% clarity on that, no.

I first attempted to go though the functions and have them exist, but be "inert" and return values that made sense, but it wasn't easy in every case, so I just did this instead.

I think this might actually make it easier for future maintainers, by removing what would essentially be inert dead code.

I added it as a PR though, so that we can have this discussion here. I am open to doing it differently as well.

KnightMiner commented 1 year ago

I don't personally use the functions so I have no preference either way. I think its just tosx who mentioned using it, so just a question of whether they would rather update to not call them or keep things working.

Lemonymous commented 1 year ago

One option could be to add the functions back in the compat file