itchannel / apex-ha

Local Neptune Apex HA Integration (Aquarium Controller)
GNU General Public License v3.0
19 stars 3 forks source link

pH is not technically a unit #26

Closed brettonw closed 1 year ago

brettonw commented 1 year ago

Perhaps if you set sensors to state class measurement, you can drop the "pH" on the unit.

brettonw commented 1 year ago

I looked at setting the state_class to measurement, but I think that will only apply to a SensorEntity. You set the unit of measurement dynamically from the config, so it might be challenging to convert to a SensorEntity (which has unit_of_measurement marked as final). As a workaround, I set the measurement to " ". The forum has a lot of discussion as to why that's not a desirable solution.

itchannel commented 1 year ago

Merged in commit from @brettonw in 1.09