itchio / butler

🎩 Command-line itch.io helper
MIT License
745 stars 52 forks source link

Rediff failure #172

Open fasterthanlime opened 5 years ago

fasterthanlime commented 5 years ago

This isn't really a public issue, although it probably has something to do with wharf's codebase (which powers butler), but I like to keep my bug in a few chosen places so:

Build 125073 fails to rediff. It says it optimizes a 240MB rsync patch into a 4.3MiB rsync+bsdiff patch, which is fishy, and then when validating the patch (applying it against the old build), it fails with EOF - which leads me to believe that somewhere when optimizing, it stops writing the patch, but an error is swallowed.

I'm very happy that optimized patches are validated before they're deployed, but this is probably an edge case in wharf that could be fixed. Unluckily, these types of bugs always seem to happen with 5GB+ games so, it might take a while to investigate!