search

itchio / butler

🎩 Command-line itch.io helper
MIT License
745 stars 52 forks source link

wrong magic (invalid input file) #183

Closed leafo closed 5 years ago

leafo commented 5 years ago

https://twitter.com/neauoire/status/1098029621457575937

dzz8gu2vyaedc3e jpg large

fasterthanlime commented 5 years ago

mystery solved: their version of butler was from 2017

image

image

leafo commented 5 years ago

maybe worth adding a version check when pushing? is there a way for the server to know and send a message back

fasterthanlime commented 5 years ago

maybe worth adding a version check when pushing? is there a way for the server to know and send a message back

well, butler push isn't supposed to break across versions - protobufs allow backward-compatible wire formats, and our signature format hasn't changed ever since the first public release. The only thing that changed is.. we've upgraded the brotli compressor/decompressor. But that's also not supposed to break, content compressed with older versions might be less optimal, but it should always be decompressible with newer versions.

So, I honestly don't know why the push failed with the build of butler from 2017. But, for a year+, butler has been doing update checks on each push, and showing a pretty large message saying to update if they're out-of-date. (We did switch from a GCS bucket to broth/itch.io, but for a few months, versions were deployed to both places).

So, I don't think it's worth it!