itchio / butler

🎩 Command-line itch.io helper
MIT License
744 stars 55 forks source link

Butler erroneously filters out manifest actions with the same path but different arguments #246

Open ChlorideCull opened 1 year ago

ChlorideCull commented 1 year ago

Basically, this code strips out all actions that point to the same binary, even if the args differ.

https://github.com/itchio/butler/blob/69bd25daddd4b6b9f2b86cd6376e6ed522accfbb/endpoints/launch/helpers.go#L157-L168

Sample manifest that triggers it:

[[actions]]
name = "play"
path = "sample.exe"

[[actions]]
name = "Configure"
path = "sample.exe"
args = ["--config"]

This is the cause of https://github.com/itchio/itch/issues/2525, most likely.