overlayBowl.move fails on Windows, when a rename occurs that's case-insensitive-equal.

itchio / itch

🎮 The best way to play your itch.io games

https://itch.io/app

MIT License

2.35k stars 209 forks source link

overlayBowl.move fails on Windows, when a rename occurs that's case-insensitive-equal. #2208

Open fasterthanlime opened 5 years ago

fasterthanlime commented 5 years ago

open D:\\Games\\Itch\\double-kick-heroes-lp\\res\\snd\\preview\\Fusion1.mp3: The system cannot find the file specified.

github.com/itchio/butler/vendor/github.com/itchio/wharf/pwr/bowl.(*overlayBowl).copy

butler version 6b4031a

for build 119710, full log: https://gist.github.com/fasterthanlime/f0d258cd67b7eb2ee103f38071213cf8

fasterthanlime commented 5 years ago

(note, there were about 10 patches queued, this was maybe the 4th?)

fasterthanlime commented 5 years ago

Healing found 1.89MiB corrupt?

fasterthanlime commented 5 years ago

After healing, patching still fails with the same error. This might be a transposition logic bug (again).

fasterthanlime commented 5 years ago

Oh cool, so

res/snd/preview/Fusion1.mp3

Has been renamed to:

res/snd/preview/fusion1.mp3

Which obviously doesn't work on windows. This is the edge case I thought would never happen.