search

itchio / itch

🎮 The best way to play your itch.io games
https://itch.io/app
MIT License
2.35k stars 209 forks source link

pelican readStringTable runtime error #2212

Open fasterthanlime opened 5 years ago

fasterthanlime commented 5 years ago

Game: https://aeondreamstudios.itch.io/to-the-edge-of-the-sky-premium itch version: 25.4.0 butler version: 15.1.0

Stack:

Error stack:
runtime error: makeslice: len out of range
github.com/itchio/butler/butlerd.(*Router).Dispatch.func2.1
    C:/Multi-Runner/builds/58469115/0/itchio/butler/src/github.com/itchio/butler/butlerd/router.go:234
runtime.call16
    C:/Go/src/runtime/asm_386.s:568
runtime.gopanic
    C:/Go/src/runtime/panic.go:513
runtime.makeslice
    C:/Go/src/runtime/slice.go:48
github.com/itchio/butler/vendor/github.com/itchio/pelican/pe.readStringTable
    C:/Multi-Runner/builds/58469115/0/itchio/butler/src/github.com/itchio/butler/vendor/github.com/itchio/pelican/pe/string.go:45
github.com/itchio/butler/vendor/github.com/itchio/pelican/pe.NewFile
    C:/Multi-Runner/builds/58469115/0/itchio/butler/src/github.com/itchio/butler/vendor/github.com/itchio/pelican/pe/file.go:104
github.com/itchio/butler/vendor/github.com/itchio/pelican.Probe
    C:/Multi-Runner/builds/58469115/0/itchio/butler/src/github.com/itchio/butler/vendor/github.com/itchio/pelican/probe.go:25
github.com/itchio/butler/endpoints/launch/launchers/native.handleAutoPrereqs.func1
    C:/Multi-Runner/builds/58469115/0/itchio/butler/src/github.com/itchio/butler/endpoints/launch/launchers/native/auto_prereqs_windows.go:65
github.com/itchio/butler/endpoints/launch/launchers/native.handleAutoPrereqs
    C:/Multi-Runner/builds/58469115/0/itchio/butler/src/github.com/itchio/butler/endpoints/launch/launchers/native/auto_prereqs_windows.go:111
github.com/itchio/butler/endpoints/launch/launchers/native.handlePrereqs
    C:/Multi-Runner/builds/58469115/0/itchio/butler/src/github.com/itchio/butler/endpoints/launch/launchers/native/prereqs.go:38
github.com/itchio/butler/endpoints/launch/launchers/native.(*Launcher).Do
    C:/Multi-Runner/builds/58469115/0/itchio/butler/src/github.com/itchio/butler/endpoints/launch/launchers/native/native.go:67
github.com/itchio/butler/endpoints/launch.Launch
    C:/Multi-Runner/builds/58469115/0/itchio/butler/src/github.com/itchio/butler/endpoints/launch/launch.go:606
github.com/itchio/butler/butlerd/messages.(*LaunchType).Register.func1
    C:/Multi-Runner/builds/58469115/0/itchio/butler/src/github.com/itchio/butler/butlerd/messages/messages.go:2733
github.com/itchio/butler/butlerd.(*Router).Dispatch.func2
    C:/Multi-Runner/builds/58469115/0/itchio/butler/src/github.com/itchio/butler/butlerd/router.go:300
github.com/itchio/butler/butlerd.(*Router).Dispatch
    C:/Multi-Runner/builds/58469115/0/itchio/butler/src/github.com/itchio/butler/butlerd/router.go:309
github.com/itchio/butler/cmd/daemon.(*handler).Handle
    C:/Multi-Runner/builds/58469115/0/itchio/butler/src/github.com/itchio/butler/cmd/daemon/daemon.go:123
runtime.goexit
    C:/Go/src/runtime/asm_386.s:1324
retropipes commented 5 years ago

I have seen this error on other games as well.

fasterthanlime commented 5 years ago

@wrldwzrd89 a list of game pages would be helpful - it's not guaranteed that fixing it for one of them would fix it for the others.

However it would be helpful if butlerd gracefully ignored those errors instead of refusing to launch. It's used only for determining prereqs, which is not a huge deal.

retropipes commented 5 years ago

I only found one game that had this issue, and since it failed to install correctly AND I didn't document which one it was at the time... I don't have the game page sadly.

fasterthanlime commented 5 years ago

@wrldwzrd89 it might show up in https://itch.io/library/things-to-rate

retropipes commented 5 years ago

Thanks. Found it... but it's a different error altogether. Opening a new issue.