Itch.io client crashes when being on twitter and go back

itchio / itch

🎮 The best way to play your itch.io games

https://itch.io/app

MIT License

2.35k stars 209 forks source link

Itch.io client crashes when being on twitter and go back #2522

Open TaraSophieDev opened 3 years ago

TaraSophieDev commented 3 years ago

In the Itch.io client's browser when you click the go back button (left arrow looking button) itch crashes. It also happens for other websites or sites but I couldn't recreate the others.

itch io twitter glitch

leafo commented 3 years ago

Sorry you're having an issue. I don't have a solution at the moment but it's likely we will be disabling all third-party websites from within the app in the future. So my recommended solution is to use twitter in your regular browser :)

TaraSophieDev commented 3 years ago

Thanks @leafo the problem is, that itch sites also sometimes crash the client.

mrkdji commented 2 years ago

I also experienced this issue.

Furthermore the app crashed while I was playing a game and I found myself unable to reopen the game on the next itch app launch: I tried to bypass the itch app but that way the game couldn't retrieve the old save data. In the end I managed to reopen the game through the app by deleting runlock.json in the folder where the game was stored. Should I open a new issue for this?

Syldarion commented 2 years ago

Also seeing this issue. Looking at task manager, it seems that this leaves a process open as well for each crash. A friend and I didn't notice at first, until his Itch instance was taking up nearly 10GB of memory. It looked like there were 10+ instances of the client running after the crashes.

milroneth commented 2 years ago

This is still an issue and I would much prefer third-party sites to open in system browser instead anyway, as we are more likely to already be logged in there.

Additionally, this put me in a crash loop, where my itch app was opening in Twitter every time, and then immediately crashed while I was trying to back out before it had time to load and had to repeat the process multiple times before I could manage to stabilise it.

Maybe not remembering the last page if it is not an itch:// URL, would be a very good idea, as they can be unpredictable, even if it's a itch.io game page, let alone a 3rd party website...

aycyang commented 2 years ago

This might be caused by a bug affecting Electron versions 10.0.0 through 18.0.0 https://github.com/electron/electron/issues/28477

My reasons for believing this:

Using WinDbg with Electron debug symbols on the itch desktop client I can see that the crash happened in the same function mentioned in that issue: RenderFrameProxyHost::SetChildRWHView
The description of the Electron issue matches this one:

If a tries to load some pages (e.g., Instagram) the doesn't render the page and then if you try and navigate the away from the page, the entire Application crashes without any visible error messages."

That issue mentions Instagram so I checked and the same thing happens as with Twitter.

Right now the itch desktop client uses Electron 11.5.0 which is among the affected Electron versions. Would it be difficult to upgrade to Electron 18.0.0 or higher?