URL routing doesn't canonicalize //, rendering 404 for new tab buttons in client - Githubissues

itchio / itch

🎮 The best way to play your itch.io games

https://itch.io/app

MIT License

2.36k stars 209 forks source link

URL routing doesn't canonicalize //, rendering 404 for new tab buttons in client #2975

Closed nc7s closed 3 months ago

nc7s commented 9 months ago

That's actually two problems:

Your backend routing doesn't canonicalize //, so //games isn't canonicalized to and recognized as /games, which should be.
The base URL constant has a slash, while added components have one too.
- https://github.com/itchio/itch/blob/102011c51dc26a3142795c67394c365bb09cb309/src/common/constants/urls.ts#L1-L2
- https://github.com/itchio/itch/blob/102011c51dc26a3142795c67394c365bb09cb309/src/renderer/pages/BrowserPage/newTabItems.ts#L33-L35

3ter commented 8 months ago

This seems like a valid improvement. Perhaps a good first issue.