Closed rionda closed 1 year ago
The background and foreground are switched automatically since events with light background in dark background colorschemes looks ugly. But your screenshots look something wrong. Let me know the result of :echo join(filter(split(execute('hi'), "\n"), 'v:val =~ "Calendar"'), "\n")
.
This is the result with background=dark
:
CalendarSelect xxx guibg=#1d424b
CalendarSunday xxx guifg=#9c1111 guibg=#957d7d
CalendarSaturday xxx guifg=#11119c guibg=#727d9f
CalendarTodaySunday xxx term=bold cterm=bold gui=bold guifg=#9c1111 guibg=#957d7d
CalendarTodaySaturday xxx term=bold cterm=bold gui=bold guifg=#11119c guibg=#727d9f
CalendarToday xxx term=bold cterm=bold gui=bold guifg=#096b20 guibg=#709380
CalendarDayTitle xxx guifg=#587176 guibg=#183e47
CalendarSundayTitle xxx guifg=#9a2c2c guibg=#957d7d
CalendarSaturdayTitle xxx guifg=#292c9c guibg=#727d9f
CalendarOtherMonth xxx guifg=#3f5d63
CalendarOtherMonthSelect xxx guifg=#3f5d63 guibg=#1d424b
CalendarNormalSpace xxx guifg=#002b36 guibg=#93a1a1
CalendarCommentSelect xxx guifg=#586e75 guibg=#1d424b
CalendarComment xxx links to Comment
Calendaramhb xxx ctermfg=231 ctermbg=63 guifg=#ffffff guibg=#3871ff
CalendaramhbSelect xxx guifg=#ffffff guibg=#023bff
Calendarmric xxx ctermfg=231 ctermbg=113 guifg=#ffffff guibg=#7add39
CalendarmricSelect xxx guifg=#ffffff guibg=#44a703
Calendarriod xxx ctermfg=152 guifg=#9fe1e7
CalendarriodSelect xxx guifg=#9fe1e7 guibg=#1d424b
Calendaramhe xxx ctermfg=176 guifg=#cd74e6
CalendaramheSelect xxx guifg=#cd74e6 guibg=#1d424b
Calendaramhf xxx ctermfg=231 ctermbg=131 guifg=#ffffff guibg=#be6536
CalendaramhfSelect xxx guifg=#ffffff guibg=#882f00
Calendaramhg xxx ctermfg=203 guifg=#fa573c
CalendaramhgSelect xxx guifg=#fa573c guibg=#1d424b
Calendaramhh xxx ctermfg=231 ctermbg=203 guifg=#ffffff guibg=#ef445e
CalendaramhhSelect xxx guifg=#ffffff guibg=#b90e28
And here is with background=light
:
CalendarSelect xxx guibg=#dcdacd
CalendarSunday xxx guifg=#f21a1a guibg=#fabfb0
CalendarSaturday xxx guifg=#1a1af2 guibg=#c4bfe6
CalendarTodaySunday xxx term=bold cterm=bold gui=bold guifg=#f21a1a guibg=#fabfb0
CalendarTodaySaturday xxx term=bold cterm=bold gui=bold guifg=#1a1af2 guibg=#c4bfe6
CalendarToday xxx term=bold cterm=bold gui=bold guifg=#34b941 guibg=#cae6ba
CalendarDayTitle xxx guifg=#9aa4a1 guibg=#e1dfd0
CalendarSundayTitle xxx guifg=#f4433f guibg=#fabfb0
CalendarSaturdayTitle xxx guifg=#4443ef guibg=#c4bfe6
CalendarOtherMonth xxx guifg=#b6bbb3
CalendarOtherMonthSelect xxx guifg=#b6bbb3 guibg=#dcdacd
CalendarNormalSpace xxx guifg=#fdf6e3 guibg=#586e75
CalendarCommentSelect xxx guifg=#93a1a1 guibg=#dcdacd
CalendarComment xxx links to Comment
Calendaramhb xxx ctermfg=27 guifg=#023bff
CalendaramhbSelect xxx guifg=#023bff guibg=#dcdacd
Calendarmric xxx ctermfg=70 guifg=#44a703
CalendarmricSelect xxx guifg=#44a703 guibg=#dcdacd
Calendarriod xxx ctermfg=0 ctermbg=195 guifg=#000000 guibg=#d5ffff
CalendarriodSelect xxx guifg=#000000 guibg=#9fe1e7
Calendaramhe xxx ctermfg=0 ctermbg=219 guifg=#000000 guibg=#ffaaff
CalendaramheSelect xxx guifg=#000000 guibg=#cd74e6
Calendaramhf xxx ctermfg=94 guifg=#882f00
CalendaramhfSelect xxx guifg=#882f00 guibg=#dcdacd
Calendaramhg xxx ctermfg=0 ctermbg=209 guifg=#000000 guibg=#ff8d72
CalendaramhgSelect xxx guifg=#000000 guibg=#fa573c
Calendaramhh xxx ctermfg=124 guifg=#b90e28
CalendaramhhSelect xxx guifg=#b90e28 guibg=#dcdacd
I fixed the implementation. I believe this should fixed the issue.
Thank you for working on it. Something changed, but I don't think it is right yet. Here are the screenshots with background=dark
and background=light
, and the outputs of the command you asked me to run.
Specifically, you'll see that with background=dark
now no event has a filled interior, and with background=light
, no event has any color at all.
background=dark
CalendarSelect xxx guibg=#1d424b
CalendarSunday xxx guifg=#9c1111 guibg=#957d7d
CalendarSaturday xxx guifg=#11119c guibg=#727d9f
CalendarTodaySunday xxx term=bold cterm=bold gui=bold guifg=#9c1111 guibg=#957d7d
CalendarTodaySaturday xxx term=bold cterm=bold gui=bold guifg=#11119c guibg=#727d9f
CalendarToday xxx term=bold cterm=bold gui=bold guifg=#096b20 guibg=#709380
CalendarDayTitle xxx guifg=#587176 guibg=#183e47
CalendarSundayTitle xxx guifg=#9a2c2c guibg=#957d7d
CalendarSaturdayTitle xxx guifg=#292c9c guibg=#727d9f
CalendarOtherMonth xxx guifg=#3f5d63
CalendarOtherMonthSelect xxx guifg=#3f5d63 guibg=#1d424b
CalendarNormalSpace xxx guifg=#002b36 guibg=#93a1a1
CalendarCommentSelect xxx guifg=#586e75 guibg=#1d424b
CalendarComment xxx links to Comment
Calendaramhb xxx ctermfg=27 guifg=#023bff
CalendaramhbSelect xxx guifg=#023bff guibg=#1d424b
Calendarmric xxx ctermfg=70 guifg=#44a703
CalendarmricSelect xxx guifg=#44a703 guibg=#1d424b
Calendarriod xxx ctermfg=152 guifg=#9fe1e7
CalendarriodSelect xxx guifg=#9fe1e7 guibg=#1d424b
Calendaramhe xxx ctermfg=176 guifg=#cd74e6
CalendaramheSelect xxx guifg=#cd74e6 guibg=#1d424b
Calendaramhf xxx ctermfg=94 guifg=#882f00
CalendaramhfSelect xxx guifg=#882f00 guibg=#1d424b
Calendaramhg xxx ctermfg=203 guifg=#fa573c
CalendaramhgSelect xxx guifg=#fa573c guibg=#1d424b
Calendaramhh xxx ctermfg=124 guifg=#b90e28
CalendaramhhSelect xxx guifg=#b90e28 guibg=#1d424b
background=light
CalendarSelect xxx guibg=#dcdacd
CalendarSunday xxx guifg=#f21a1a guibg=#fabfb0
CalendarSaturday xxx guifg=#1a1af2 guibg=#c4bfe6
CalendarTodaySunday xxx term=bold cterm=bold gui=bold guifg=#f21a1a guibg=#fabfb0
CalendarTodaySaturday xxx term=bold cterm=bold gui=bold guifg=#1a1af2 guibg=#c4bfe6
CalendarToday xxx term=bold cterm=bold gui=bold guifg=#34b941 guibg=#cae6ba
CalendarDayTitle xxx guifg=#9aa4a1 guibg=#e1dfd0
CalendarSundayTitle xxx guifg=#f4433f guibg=#fabfb0
CalendarSaturdayTitle xxx guifg=#4443ef guibg=#c4bfe6
CalendarOtherMonth xxx guifg=#b6bbb3
CalendarOtherMonthSelect xxx guifg=#b6bbb3 guibg=#dcdacd
CalendarNormalSpace xxx guifg=#fdf6e3 guibg=#586e75
CalendarCommentSelect xxx guifg=#93a1a1 guibg=#dcdacd
CalendarComment xxx links to Comment
Calendaramhb xxx ctermfg=60 ctermbg=63 guifg=#586e75 guibg=#3871ff
CalendaramhbSelect xxx guifg=#586e75 guibg=#023bff
Calendarmric xxx ctermfg=60 ctermbg=113 guifg=#586e75 guibg=#7add39
CalendarmricSelect xxx guifg=#586e75 guibg=#44a703
Calendarriod xxx ctermfg=0 ctermbg=195 guifg=#000000 guibg=#d5ffff
CalendarriodSelect xxx guifg=#000000 guibg=#9fe1e7
Calendaramhe xxx ctermfg=0 ctermbg=219 guifg=#000000 guibg=#ffaaff
CalendaramheSelect xxx guifg=#000000 guibg=#cd74e6
Calendaramhf xxx ctermfg=60 ctermbg=131 guifg=#586e75 guibg=#be6536
CalendaramhfSelect xxx guifg=#586e75 guibg=#882f00
Calendaramhg xxx ctermfg=0 ctermbg=209 guifg=#000000 guibg=#ff8d72
CalendaramhgSelect xxx guifg=#000000 guibg=#fa573c
Calendaramhh xxx ctermfg=60 ctermbg=203 guifg=#586e75 guibg=#ef445e
CalendaramhhSelect xxx guifg=#586e75 guibg=#b90e28
Sorry, I fixed again.
Yes, looks good now! Thanks!
Although, it would be nice to allow to have a filled interior also in dark
mode, if possible?
You've hit some corner cases, but it is intentional design of this plugin for dark background. I always use this plugin with dark background since I created years ago, it looks like that since its beginning, and I think it's looks better without filled colors in dark background.
The colors used to show the events seems to be mapped to the ones set in google for the calendar the event corresponds to, but I'm seeing an issue where only the frame of the events of one specific calendar is colored, and the interior of the event is "transparent", i.e., it just has the background color. Moreover, this changes when using
set background=light
vsset background=dark
. The screenshots below give an idea: the event "emails" on Monday has a "transparent" interior whenset background=dark
, and it has a "filled" interior whenset background=light
. The opposite happens for the events in the other calendars (see screenshots).So, the question is: how are the colors chosen, and what controls whether the interior of an event is filled or not?
Screenshot with
background=dark
Screenshot with
background=light