search

itchyny / calendar.vim

A calendar application for Vim
MIT License
1.95k stars 72 forks source link

Option to show week numbers #53

Closed lervag closed 9 years ago

lervag commented 10 years ago

I propose that you add an option to show week numbers in the calendar.

itchyny commented 10 years ago

I implemented. You can enable week numbers by

let g:calendar_week_number = 1

The default value is 0.

lervag commented 10 years ago

Great, thanks!

mMontu commented 9 years ago

I noticed that the week numbers doesn't show with '-view=year', is this the expected behavior?

itchyny commented 9 years ago

Seems that I did not implement because it'd be more difficult to implement in the year view than in the month view and was less motivated since I've never seen any calendars showing week numbers. But looks inconsistent so I'll implement when I have time to.

mMontu commented 9 years ago

OK, thanks for the explanation. I've find them very useful some years ago, though currently I don't use. I noticed they had disappeared on the new version and thought this was an error caused by interaction with some other plugin. So I'm fine with the current form, and I have to say that its appearance improved a great deal. Nice work!

itchyny commented 9 years ago

Thank you for your comment. I actually get glad to see Nice work! comments in the issues because most people install and just think that the plugin is good/bad. One thing to point out is that there are two calendar plugins for Vim; the calendar plugin you used years ago was written by mattn and the plugin in this repository is a totally rewritten plugin by me. So week numbers did not implemented in the new plugin by me, not disappeared.

lervag commented 9 years ago

Just wanted to add that I also really like this plugin! You've done a great job, @itchyny! :)

itchyny commented 9 years ago

Thank you @lervag!

mMontu commented 9 years ago

It works like a charm!

I really thought this was a new version of plugin_id=52. Now I see that the whole history is on :help calendar-introduction.

I've searched the vim.org and didn't find a reference to this plugin. I think it could be a good idea to insert it there, as many people use that page when searching for plugins.

Once again, thank you very much :)

itchyny commented 9 years ago

My pleasure.

I want to create a tag and upload this plugin to vim.org after closing all the feature requests.