search

itdelatrisu / opsu

opsu! ~ an open-source osu! client
https://itdelatrisu.github.io/opsu/
GNU General Public License v3.0
762 stars 123 forks source link

Skins in general aren't working for me #416

Open Achelmic opened 6 years ago

Achelmic commented 6 years ago

Whenever I put skins in the format of ".osk" in the Skins folder it does not show up in the drop down of in the settings interface. Ive tried putting the .osk files in import to see if import was used for unzipping the skin files as well but it didnt work. im not sure if the feature is even added but I would like to have a skin on though I am having trouble in such that I described.

limjs6708 commented 6 years ago

If the .osk doesn't work for u just rename the .osk file into a .zip file. After that unzip the file and put it in opsu/Skins

tpenguinltg commented 6 years ago

@Achelmic What's your OS and opsu! version? We do have support for skins and they should be handled on import if they're in the Import folder. Try clearing your Skins directory and putting it in the Import folder again.

Achelmic commented 6 years ago

OS version 10.13.3 high sierra opsu version of v0.16.1

also you mean by putting the skin as putting the raw osu extension one in or the folder in?

tpenguinltg commented 6 years ago

Thanks. Yes, put the .osk file in the Import folder.

Achelmic commented 6 years ago

I put the .osk file in import and it didn't work, I tried pressing "import all" as well and that didn't work as well, I can't seem to find a solution?

As well as I tried another skin and this time these file types didn't work for it count1s.wav count2s.wav count3s.wav gos.wav and it froze again on soft-hitclap.wav I know that opsu! supports .wav file extensions because I saw some in loading pass, but I'm wondering for the opsu! file if those files can replace stuff because I'm thinking that maybe for opsu those files don't exist so that's why there's an error because the ones in skins cant replace anything

"Invalid data found on audio file '/Users/achelmic/Desktop/Skins/- Seouless' v7+16-9/count1s.wav'. javax.sound.sampled.UnsupportedAudioFileException: could not get audio input stream from input URL at javax.sound.sampled.AudioSystem.getAudioInputStream(AudioSystem.java:1155) at itdelatrisu.opsu.audio.SoundController.loadClip(SoundController.java:99) at itdelatrisu.opsu.audio.SoundController.init(SoundController.java:234) at itdelatrisu.opsu.states.Splash$1.run(Splash.java:138)"

"Invalid data found on audio file '/Users/achelmic/Desktop/Skins/- Seouless' v7+16-9/count2s.wav'. javax.sound.sampled.UnsupportedAudioFileException: could not get audio input stream from input URL at javax.sound.sampled.AudioSystem.getAudioInputStream(AudioSystem.java:1155) at itdelatrisu.opsu.audio.SoundController.loadClip(SoundController.java:99) at itdelatrisu.opsu.audio.SoundController.init(SoundController.java:234) at itdelatrisu.opsu.states.Splash$1.run(Splash.java:138)"

"Invalid data found on audio file '/Users/achelmic/Desktop/Skins/- Seouless' v7+16-9/count3s.wav'. javax.sound.sampled.UnsupportedAudioFileException: could not get audio input stream from input URL at javax.sound.sampled.AudioSystem.getAudioInputStream(AudioSystem.java:1155) at itdelatrisu.opsu.audio.SoundController.loadClip(SoundController.java:99) at itdelatrisu.opsu.audio.SoundController.init(SoundController.java:234) at itdelatrisu.opsu.states.Splash$1.run(Splash.java:138)"

"Invalid data found on audio file '/Users/achelmic/Desktop/Skins/- Seouless' v7+16-9/gos.wav'. javax.sound.sampled.UnsupportedAudioFileException: could not get audio input stream from input URL at javax.sound.sampled.AudioSystem.getAudioInputStream(AudioSystem.java:1155) at itdelatrisu.opsu.audio.SoundController.loadClip(SoundController.java:99) at itdelatrisu.opsu.audio.SoundController.init(SoundController.java:234) at itdelatrisu.opsu.states.Splash$1.run(Splash.java:138)"

Achelmic commented 6 years ago

Okay I think I found a solution through its not proper, I removed those file types from the skin folder which I turned from a .osk to .zip and unzipped it, I have done such and removed the 5 files that wouldn't load and sure enough the skin is working now, I believe I have fixed this and it seems it wouldn't load just the five with the 5th being "soft-hitclap.wav"

tpenguinltg commented 6 years ago

When you put the .osk in your Import folder, you have to delete the existing skin in the Skins folder if you previously tried to extract it, otherwise it might not extract. It will be imported the next time you launch opsu!.

We have unresolved issues with what may have to do with silent WAVs (see #393; #391, #402 and #409 may also be related). I took a look at the sound files for the "- Seouless' v7+16-9" skin and it looks like the first four you listed are silent.