itdelatrisu / opsu

opsu! ~ an open-source osu! client
https://itdelatrisu.github.io/opsu/
GNU General Public License v3.0
763 stars 123 forks source link

Showing time #481

Open ccppoo opened 5 years ago

ccppoo commented 5 years ago

Hi I bumped in this project a few days ago, and almost used as a music player rather than playing as game ;(

first of all I'm Korean(GMT +9), and I didn't opened the source code but I just want to know If other languages also happens too. It looks like auto localized image

where I circled ("오오") should be looked like ("오전") meaning morning(a.m.)

If there's anyone having the similar problem comment please

itdelatrisu commented 5 years ago

I have no idea why this would happen. :(

Relevant code: https://github.com/itdelatrisu/opsu/blob/master/src/itdelatrisu/opsu/states/MainMenu.java#L481

tpenguinltg commented 5 years ago

@ccppoo Does 오오 appear for any other programs that show AM/PM markers? If so, you should fix that in your OS settings. I suspect that it lifts the locale strings from the system if a locale is not explicitly given. I tried forcing the Korean locale, but I couldn't get it to show the markers.

If you have a JDK installed, perhaps you can also try compiling a very minimal example?

Save the following as FormatTest.java:

import java.text.SimpleDateFormat;
import java.util.Date;

public class FormatTest {
  public static void main(String[] args) {
    System.out.println(new SimpleDateFormat("h:mm a").format(new Date()));
  }
}

Then run

javac FormatTest.java
java FormatTest

and see what gets printed.

ccppoo commented 5 years ago

@itdelatrisu I'll try it, create pull request if anything is fixed

@tpenguinltg thanks for test sample, and I got image it works well. It's the first time that I saw the word "오" duplicated. I'll try to fix it, and will create pull request.

tpenguinltg commented 5 years ago

Ah, so it is a rendering problem (probably). I thought it looked odd that the second "오" was slightly raised compared to the first.