Feature Request: Improve responsiveness of UI/API by changing mDNS browse thread to use callback feature in Zeroconf

itead / Sonoff_Devices_DIY_Tools

BSD 3-Clause "New" or "Revised" License

548 stars 168 forks source link

Closed mattsaxon closed 4 years ago

mattsaxon commented 5 years ago

I've noticed that the Zeroconf implementation doesn't allow notification and as a result this code must to a busy polling (currently every 0.5s).

In an effort to improve the responsiveness of this code, I've submitted a draft PR to improve Zeroconf here for this purpose. https://github.com/jstasiak/python-zeroconf/pull/166

I though you would be interested.

ZZLinvec commented 5 years ago

Thank you very much，I will follow up later.

mattsaxon commented 5 years ago

The PR has not been accepted (https://github.com/jstasiak/python-zeroconf/pull/166) so is in latest copy of branch, though PyPi is yet to include this update.

mattsaxon commented 5 years ago

PyPi now has this change under release 0.23.0 https://pypi.org/project/zeroconf/0.23.0/

ZZLinvec commented 4 years ago

nice