[Language Server] LS must not contain UI bundles

itemisCREATE / solidity-ide

Solidity plugin for Eclipse

Eclipse Public License 1.0

87 stars 25 forks source link

[Language Server] LS must not contain UI bundles #242

Closed kthoms closed 5 years ago

kthoms commented 5 years ago

The language server application built contains some UI bundles, e.g. org.eclipse.ui or org.eclipse.swt. This inidcates that there are some dependency issues with solidity.ide. The resulting application built should not contain them.

nyssen commented 5 years ago

It seems this is introduced through a dependency from com.yakindu.solidity.compiler to org.eclipse.xtext.ui (SolidityMarkerCreator extends MarkerCreator, which is provided by org.eclipse.xtext.ui.editor), where com.yakindu.solidity.compiler is required by com.yakindu.solidity.ide.

andreasmuelder commented 5 years ago

@flantony can we move the marker creator to the solidity.ui bundle?