check error/warning validation messages for expressiveness

itemisCREATE / statecharts

YAKINDU Statechart Tools (http://www.statecharts.org)

Eclipse Public License 1.0

174 stars 84 forks source link

check error/warning validation messages for expressiveness #2203

Closed tangele closed 5 years ago

tangele commented 5 years ago

in a usability test, we noticed that an user (who received the "missing trigger" warning) didn't knew where he was expected to add the missing trigger.
in the case of the error message ”local declarations are not allowed in interface scope”, the same user was wondered how to fix that. He had defined an event without using the in or out keyword.
always 30s results in the error message missing EOF at '30'
- I would expect that the parser would already fail when trying to parse 30.

andreasmuelder commented 5 years ago

We should check if we can replace the default xtext messages like

missing EOF at
couldn't resolve reference to EObject with more expressive messages

tangele commented 5 years ago

additionally:

interface:
var test:boolean = valueof(noSuchName)

creates the error:

Couldn't resolve reference to EObject 'noSuchName'. default2.sct    /issue_2238 line: 1 /issue_2238/default2.sct    Statechart Check (Fast)
is no event.    default2.sct    /issue_2238 line: 21 /issue_2238/default2.sct   Statechart Check (Fast)

1) in this case, EObject should be replaced by event. 2) "is no event" is ugly.