Collection of bugs in the SCT C# Generator

jthoene commented 6 years ago

The evaluation of the SCT C# Generator brought the following results:

Minor Bugs: Name convention in C#:

Compile Problems:

If you have multiple statecharts and don't define explicitly the namespace in the sgen file all clases and interfaces will be generated in the same namespace and therefore multiple SCInterface interfaces are defined in the same namespace, which results in compilation errors
At some points in the code ".this" is used instead of a simple "this"
At some points in the code "boolean" is generated instead of "bool"
The classes "IRunnableTestStatemachine", "TimerService" and "RuntimeService" need to be reimplemented in C#, currently there is only the corresponding Java Implementation copied and generated

Test models from "org.yakindu.sct.test.models" which don't compile at the moment:

Generator Exceptions were thrown for the following test models from "org.yakindu.sct.test.models":

The following bugs are already fixed on the branch "c#_generator_refactoring":

int used instead of long, because only with int the shift operators are usable
Missing closing bracket for the init function if a history vector is initialized
Correcting "State.$Nullstate$" to "State.Nullstate"
Changed the visibility of the sealed classes from private to protected
Changed all private Methods to protected or, if they were private methods in a sealed protected classe, which were called outside of the sealed class to public
Changed the visibility of all private attributes to protected

BeckmaR commented 6 years ago

Please open PR's as frequently as possible to simplify the review process :)

rherrmannr commented 6 years ago

- Missing closing bracket for the init function if a history vector is initialized
- Correcting "State.$Nullstate$" to "State.Nullstate"

itemisCREATE / statecharts