itemsapi / itemsjs

Extremely fast faceted search engine in JavaScript - lightweight, flexible, and simple to use
Apache License 2.0
350 stars 41 forks source link

Use NWB to build module #13

Closed saminzadeh closed 6 years ago

saminzadeh commented 6 years ago

This should address #12 as well as accomplish the following:

Additional Ideas in the future Instead of checking in the subset of lodash files, you can use the Lodash babel plugin to automatically include the functions that you are using in lodash. This will be more effective, so people can dedupe dependencies if they include your library in their own bundles.

cigolpl commented 6 years ago

@saminzadeh it looks great! thanks for contribution. I am not super familiar of frontend tools like babel / nwb so that's particularly appreciated

In terms of babel plugin for lodash - I was experimenting with another but quite similar solution but afaik I had a problem with real minification. If babel plugin makes codebase smaller or more flexible in terms of extending this library by another developers then that's great idea

saminzadeh commented 6 years ago

@cigolpl No problem! Do you have a process for publishing to NPM?

As for the babel plugin, I could create another PR for this. The lodash plugin should strip the stuff thats not used, then webpack will bundle and minify it.

cigolpl commented 6 years ago

@saminzadeh that sounds great. Usually I was doing that manually but it was easy to make a mistake and I didn't like the process. Such a automation will make it definitely simpler for development