search

itemsapi / itemsjs

Extremely fast faceted search engine in JavaScript - lightweight, flexible, and simple to use
Apache License 2.0
350 stars 41 forks source link

Refactor fulltext #136

Closed stereobooster closed 1 year ago

stereobooster commented 1 year ago

Up to you - if you like this refactoring or not

stereobooster commented 1 year ago

hm strange... tests (github CI) are not running for pull request

stereobooster commented 1 year ago

And there is second-copy of store in Facets - this._items_map. Maybe it can be refactored somehow to store only copy of "map".

cigolpl commented 1 year ago

Yes, the code looks much cleaner now, is more readable and uses modern JS.

hm strange... tests (github CI) are not running for pull request

IMO .github/workflows/push.yml is missing pull_request in 3rd line 

on: [push, pull_request]