search

iter8-tools / iter8

Kubernetes release optimizer
https://iter8.tools
Apache License 2.0
256 stars 34 forks source link

Remove AddFinalizer event #1484

Closed kalantar closed 1 year ago

kalantar commented 1 year ago

Manual stress testing produces the following error on rare occasions:

k8s.io/client-go/tools/record.(*recorderImpl).Event(0xc009c16d20?, {0x2bdf0d8?, 0x0?}, {0x27df624?, 0x0?}, {0x280249e?, 0xc0006671f0?}, {0x28252cc?, 0xc0006671f0?})
    k8s.io/client-go@v0.26.3/tools/record/event.go:363 +0x4f
github.com/iter8-tools/iter8/controllers.broadcastEvent({0x2bdf0d8, 0x0}, {0x27df624, 0x6}, {0x280249e, 0x15}, {0x28252cc, 0x22}, {0x2c16f28, 0xc00094f9b0})
    github.com/iter8-tools/iter8/controllers/events.go:23 +0x1de
github.com/iter8-tools/iter8/controllers.addFinalizer.func1()
    github.com/iter8-tools/iter8/controllers/finalizer.go:78 +0xb12

To Reproduce Observed running 150 apps (configmaps) each in loop that does:

deploy candidate
sleep 5
promote candidate
sleep 5

Expected behavior No crash.

kalantar commented 1 year ago

Remove AddFinalizer event. Not needed.