iter8-tools / iter8

Kubernetes release optimizer
https://iter8.tools
Apache License 2.0
256 stars 34 forks source link

Is `NumUsers` redundant? #1519

Closed Alan-Cha closed 1 year ago

Alan-Cha commented 1 year ago

NumUsers in VersionMetricSummary (see here) exists along side of Count in SummaryOverUsers and SummaryOverTransactions (see here)

My original impressions was that NumUsers may be different from Count. However, if we intended to add 0s for metrics over users for users that did not set any metrics (lookup()), then the Count for SummaryOverUsers should always equal NumUsers.

If that is the case, then NumUsers may be redundant and could be removed.

kalantar commented 1 year ago

addressed by other changes