search

iter8-tools / iter8

Kubernetes release optimizer
https://iter8.tools
Apache License 2.0
253 stars 34 forks source link

Remove Revision number #1583

Closed Alan-Cha closed 10 months ago

Alan-Cha commented 11 months ago

Should Revision be removed from Experiment?

What are the implications of removing this? What do we want the expected behavior of rerunning experiments going forward?

Alan-Cha commented 11 months ago

We will keep it in for now. It is a benign feature and will require more cycles.

kalantar commented 10 months ago

Even with move to helm upgrade we still have revisions.

sriumcp commented 10 months ago

Revision number ensures that the old job spec is deleted and a new job spec is created whenever an experiment is upgraded. Without the revision number, helm will not recreate a job, so helm upgrade will not result in a new experiment run.