kalantar
commented
10 months ago Since the controller and iter8 charts are different charts, the map resourceTypes will need to be duplicated.
It would be best if the map is the same. Currently, there are two discrepancies between them. - in the ready task, the key service is used for a Kubernetes service. In the controller, the key svc is used
- in the ready task, only one condition can be specified; its value must be
True. In the controller, a list of conditions can be specified along with a list of values.
To address this, propose:
- Provide by
serviceandsvcinresourceTypesfor both charts. (no code changes) - allow multiple conditions in both but require
True. No reason to allow other values. (change to both implementations)
Today to extend readiness task to other resource types, it is necessary to modify two helm templates in the iter8 chart:
_task-ready.tpland_k-role.tpl. For details, see https://iter8.tools/0.16/user-guide/tasks/ready/An alternative is to use a map of
resourceTypesinvalues.yamlsimilar to what is done in the controller chart. This can be used to create the ready tasks and define the roles.