Closed kalantar closed 1 year ago
Since the controller and iter8 charts are different charts, the map resourceTypes
will need to be duplicated.
It would be best if the map is the same. Currently, there are two discrepancies between them. - in the ready task, the key service
is used for a Kubernetes service. In the controller, the key svc
is used
True
. In the controller, a list of conditions can be specified along with a list of values.To address this, propose:
service
and svc
in resourceTypes
for both charts. (no code changes)True
. No reason to allow other values. (change to both implementations)@Alan-Cha @sriumcp
work in progress is here: https://github.com/iter8-tools/iter8/pull/1636
Today to extend readiness task to other resource types, it is necessary to modify two helm templates in the iter8 chart:
_task-ready.tpl
and_k-role.tpl
. For details, see https://iter8.tools/0.16/user-guide/tasks/ready/An alternative is to use a map of
resourceTypes
invalues.yaml
similar to what is done in the controller chart. This can be used to create the ready tasks and define the roles.