iter8-tools / iter8

Kubernetes release optimizer
https://iter8.tools
Apache License 2.0
256 stars 34 forks source link

Simplify extension of readiness task #1635

Closed kalantar closed 1 year ago

kalantar commented 1 year ago

Today to extend readiness task to other resource types, it is necessary to modify two helm templates in the iter8 chart: _task-ready.tpl and _k-role.tpl. For details, see https://iter8.tools/0.16/user-guide/tasks/ready/

An alternative is to use a map of resourceTypes in values.yaml similar to what is done in the controller chart. This can be used to create the ready tasks and define the roles.

kalantar commented 1 year ago

Since the controller and iter8 charts are different charts, the map resourceTypes will need to be duplicated.

It would be best if the map is the same. Currently, there are two discrepancies between them. - in the ready task, the key service is used for a Kubernetes service. In the controller, the key svc is used

To address this, propose:

kalantar commented 1 year ago

@Alan-Cha @sriumcp

kalantar commented 1 year ago

work in progress is here: https://github.com/iter8-tools/iter8/pull/1636

kalantar commented 1 year ago

completed by https://github.com/iter8-tools/iter8/pull/1639 and https://github.com/iter8-tools/iter8/pull/1640