search

iterate-ch / profiles

Connection Profiles for Cyberduck & Mountain Duck
14 stars 29 forks source link

Default Microsoft Graph Client Id should be configurable #78

Open AliveDevil opened 7 months ago

AliveDevil commented 7 months ago

With different client ids for Cyberduck and Mountain Duck, the SharePoint Site-profile listed here doesn't work in Mountain Duck (x-mountainduck-action is not set as a valid redirect URI for the Cyberduck application).

dkocher commented 7 months ago

Supposed to be fixed with 755731c2.

AliveDevil commented 7 months ago

Client Id is still the same: https://github.com/iterate-ch/profiles/blob/e4f130d4a160d66d7ae8110edd7cbb697d753feb/Microsoft%20SharePoint%20Site.cyberduckprofile#L49

AliveDevil commented 7 months ago

Add default-property microsoft.graph.clientid, which can be set to <string>${microsoft.graph.clientid}</string> in this profile? Would allow removing the duplicate profile in Mountain Duck for OneDrive and SharePoint as well, when using a default-property.

dkocher commented 7 months ago

Add default-property microsoft.graph.clientid, which can be set to <string>${microsoft.graph.clientid}</string> in this profile? Would allow removing the duplicate profile in Mountain Duck for OneDrive and SharePoint as well, when using a default-property.

I have added x-mountainduck-action://oauth to the app registration of f40bc18f-cd02-4212-b7f1-15243e4e2ad3 as a temporary workaround.