In openopc2.da_client.OpcDaClient, there is some awkward statefulness:
open_opc_config = OpenOpcConfig()
open_opc_config.OPC_SERVER = opc_server # Pretend no env vars for now
opc_client = OpcDaClient(open_opc_config=open_opc_config)
opc_client.connect(opc_server=opc_server)
The statefulness comes from:
Having to embed opc_server into OpenOpcConfig, only for OpcDaClient never to use self.opc_server
Having to pass opc_server again to opc_client.connect
Just pointing out this is awkward, and to me indicates room for a better design.
renzop
commented
1 year ago
In
openopc2.da_client.OpcDaClient, there is some awkward statefulness:The statefulness comes from:
opc_serverintoOpenOpcConfig, only forOpcDaClientnever to useself.opc_serveropc_serveragain toopc_client.connectJust pointing out this is awkward, and to me indicates room for a better design.