search

iterative / PyDrive2

Google Drive API Python wrapper library. Maintained fork of PyDrive.
https://docs.iterative.ai/PyDrive2
Other
570 stars 70 forks source link

Add device auth and redis credential storage #266

Closed zeroday0619 closed 1 year ago

zeroday0619 commented 1 year ago

device auth => https://developers.google.com/identity/protocols/oauth2/limited-input-device

shcheklein commented 1 year ago

@zeroday0619 thanks! if these things (Redis and device auth) are independent, let's as a first step please split this into two PRs. This way it'll be way easier to move with this forward. Thanks!

zeroday0619 commented 1 year ago

How can I divide PR into two?

@zeroday0619 thanks! if these things (Redis and device auth) are independent, let's as a first step please split this into two PRs. This way it'll be way easier to move with this forward. Thanks!

shcheklein commented 1 year ago

How can I divide PR into two?

Sure. You would need to close this one, cherry-pick the changes that are related specifically to the device auth and create a new PR. Then pick the changes related to redis and do another PR.

Does it makes sense @zeroday0619 ?

zeroday0619 commented 1 year ago

How can I divide PR into two?

Sure. You would need to close this one, cherry-pick the changes that are related specifically to the device auth and create a new PR. Then pick the changes related to redis and do another PR.

Does it makes sense @zeroday0619 ?

Do I make 2 branch and create a separate PR? Am I right in understanding?

shcheklein commented 1 year ago

Do I make 2 branch and create a separate PR?

Yes.

zeroday0619 commented 1 year ago

I understand. I'll proceed with the separation and create a PR. Thank you.

shcheklein commented 1 year ago

@zeroday0619 thanks! 🙏

zeroday0619 commented 1 year ago

done!

shcheklein commented 1 year ago

Closing this in favor of #267 and #268 . We still need some cleanup in both PRs to make sure they have only changes per the PR purpose.