search

iterative / PyDrive2

Google Drive API Python wrapper library. Maintained fork of PyDrive.
https://docs.iterative.ai/PyDrive2
Other
570 stars 70 forks source link

GDriveFileSystem: Raise `FIleNotFoundError` on `ls`. #283

Closed daavoo closed 1 year ago

daavoo commented 1 year ago

Per https://github.com/iterative/dvc-gdrive/issues/29

skshetry commented 1 year ago

Investigating some failures in https://github.com/iterative/dvc-gdrive/pull/28. Will merge this after they turn green.

skshetry commented 1 year ago

Looks like find() is also not working correctly. Will look into it next week.

daavoo commented 1 year ago

Looks like find() is also not working correctly. Will look into it next week.

What is the failure or case where is not working?

skshetry commented 1 year ago

Looks like find() is also not working correctly. Will look into it next week.

What is the failure or case where is not working?

See https://github.com/iterative/dvc-gdrive/pull/28. The following returns an empty list even though the file exists, failing status checks.

>>> fs.find("root/<>/files/md5")
[]

I am still trying to understand internals of GDriveFileSystem on how to fix it.

This piece of code is problematic:

https://github.com/iterative/PyDrive2/blob/a5dc1d9a4da73f8b4172c1020726bd457fb62213/pydrive2/fs/spec.py#L476-L482