pydrive2: use isinstance() instead of type()

iterative / PyDrive2

Google Drive API Python wrapper library. Maintained fork of PyDrive.

https://docs.iterative.ai/PyDrive2

Other

570 stars 70 forks source link

pydrive2: use isinstance() instead of type() #291

Closed efiop closed 1 year ago

efiop commented 1 year ago

Looks like this was an anti pattern that stuck around from some early days.

Fixes https://github.com/iterative/dvc-gdrive/issues/31

efiop commented 1 year ago

@shcheklein Did consider it, but I don't think it is worth it. It is just an anti-pattern that needed to be fixed (and linters, which are unfortunately not enabled apparently, should catch this).

Will wait a bit for the confirmation from the user.