iterative / PyDrive2

Google Drive API Python wrapper library. Maintained fork of PyDrive.
https://docs.iterative.ai/PyDrive2
Other
570 stars 70 forks source link

Add .GetRevisions() option #297

Closed rasa closed 1 year ago

rasa commented 1 year ago

The code works, but I'm unable to figure out how to install the extras_require packages to get the tests to run.

shcheklein commented 1 year ago

@rasa thanks! pre-commit hook fails, please check the output, run linters locally to fix it. After that we can run the tests on CI.

The code works, but I'm unable to figure out how to install the extras_require packages to get the tests to run.

Has to be something like (in a virtualenv):

pip install -e ".[tests]"
rasa commented 1 year ago

pip install -e ".[tests]"

Thanks! I tried pip install -e ".[extras]" before, but it didn't work. I just ran pip install -e ".[tests]" but then I needed to run pip install -e ".[fsspec]" as fsspec and appdirs needed to be installed.

If I had foresight, I would have checked here where I would have found python -m pip install -e '.[fsspec, tests]'

When I run the tests, the first Google Signin works, but the next two just spin forever at

pydrive2/test/test_apiattr.py F                                                                                                                                                      [  2%]
pydrive2/test/test_drive.py E                                                                                                                                                        [  4%]
pydrive2/test/test_file.py EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEsEEEE                                                                                                                  [ 58%]
pydrive2/test/test_filelist.py EEEE                                                                                                                                                  [ 63%]
pydrive2/test/test_fs.py .FFEEEEEEEEEEEE                                                                                                                                             [ 83%]
pydrive2/test/test_oauth.py .F
shcheklein commented 1 year ago

@rasa looks like also Python 3.8 / 3.9 tests fail. Please check the logs above.

rasa commented 1 year ago

@rasa looks like also Python 3.8 / 3.9 tests fail. Please check the logs above.

The logs show the same error that occurred on July 10 in these logs so I don't think the issue is with my PR. The July 5 run was the last to succeed.

Edit: Perhaps we need to pin the specific Python version? I can look into that in a few hours.

shcheklein commented 1 year ago

Yes, you are right, most likely PyInstaller got updated actually. We'll check that.

shcheklein commented 1 year ago

@rasa thanks! I've merged it and triggered the release process.