search

iterative / cml.dev

🔗 CML website and documentation
https://cml.dev
Apache License 2.0
12 stars 23 forks source link

docs: fixup GitHub workflows #357

Closed casperdcl closed 1 year ago

casperdcl commented 1 year ago
github-actions[bot] commented 1 year ago

9a58829

Link Check Report

There were no links to check!

CML watermark

0x2b3bfa0 commented 1 year ago

I'm a bit confused with https://github.com/iterative/cml.dev/pull/357/commits/334d25fad7ba8ba5530536fa3bb6f52b794c4cbc 🤔

If the workflow triggers on push shouldn't the github.event payload be different?

casperdcl commented 1 year ago

Yes github.event.pull_request.head.sha will be blank on: push and work correctly (checking out a branch rather than SHA), right?

I'm leaving github.event.pull_request.head.sha as-is anyway just in case pple modify to use on: pull_request.

Related: https://github.com/iterative/example-get-started/pull/31 deserves a technical write-up.