iterative / cml.dev

🔗 CML website and documentation
https://cml.dev
Apache License 2.0
12 stars 23 forks source link

Update theme to 0.2.x #402

Closed yathomasi closed 1 year ago

yathomasi commented 1 year ago

Similar to https://github.com/iterative/dvc.org/pull/4118 for cml.dev.

github-actions[bot] commented 1 year ago

3e3aadf

Link Check Report

There were no links to check!

rogermparent commented 1 year ago

image Looks like we'll have to shadow some colors and/or improve the theme-changing support. I think we can simply shadow the CSS file for minimal duplication, but we can at least use the theme's content component even if we have to replace the wrapper.

yathomasi commented 1 year ago

Looks like we'll have to shadow some colors and/or improve the theme-changing support. I think we can simply shadow the CSS file for minimal duplication, but we can at least use the theme's content component even if we have to replace the wrapper.

I just used the same approach 😄. It's working fine locally and let's see how it goes to preview deployment as the previous one was also fine locally but not on preview deployment.

rogermparent commented 1 year ago

Looking great! I've been clicking around and can only see one final thing wrong: we need scroll-margin-top/scroll-padding-top for anchor links so clicking internal links works properly.

After that, I think we're ready for approval!

https://user-images.githubusercontent.com/9111807/207768262-fb521bda-60aa-4736-a0c8-9779853b597b.mp4