search

iterative / cml

♾️ CML - Continuous Machine Learning | CI/CD for ML
http://cml.dev
Apache License 2.0
4.03k stars 341 forks source link

handle paths with spaces #1373

Closed Autodidact24 closed 5 months ago

Autodidact24 commented 1 year ago

Resolving #1369

We can use the encodeURIComponent function to encode any spaces in the node.url property before passing it to the path.resolve function.

This should ensure that image URLs with spaces are resolved correctly and passed to the publish function.

github-actions[bot] commented 1 year ago

Test Comment

github-actions[bot] commented 1 year ago

Test Comment

0x2b3bfa0 commented 1 year ago

Thanks, @Autodidact24! Can you please add a test case for the changes introduced on this pull request? Sorry for the late reply.

0x2b3bfa0 commented 1 year ago

By the way, why does path.resolve need arguments to be URL-encoded? 🤔