iterative / cml

♾️ CML - Continuous Machine Learning | CI/CD for ML
http://cml.dev
Apache License 2.0
4.03k stars 341 forks source link

fix: replace deprecated gitlab ci var #1404

Closed nipierre closed 1 year ago

nipierre commented 1 year ago

GitLab 16.x deprecated several variables including CI_BUILD_REF_NAME. In order to be exhaustive, two variables are replacing it: CI_COMMIT_BRANCH (prefered) and CI_COMMIT_REF_NAME.

Issue: #1403

I put the two variables in order to cover most of the cases one can think of in terms of pipeline trigger.

@dacbd

github-actions[bot] commented 1 year ago

Test Comment

github-actions[bot] commented 1 year ago

Test Comment

github-actions[bot] commented 1 year ago

Test Comment

github-actions[bot] commented 1 year ago

Test Comment

nipierre commented 1 year ago

@dacbd I fixed the credentials build missing argument.

dacbd commented 1 year ago

@nipierre Thanks, I'm addressing a container issue that is blocking some of our automation, my plan is to try and have this merged and released by the end of the week for you.

Thanks again for this patch!

github-actions[bot] commented 1 year ago

Test Comment

github-actions[bot] commented 1 year ago

Test Comment

github-actions[bot] commented 1 year ago

Test Comment

github-actions[bot] commented 1 year ago

Test Comment

github-actions[bot] commented 1 year ago

Test Comment

github-actions[bot] commented 1 year ago

Test Comment