Really deprecate dvcorg/cml-py3 - Githubissues

iterative / cml

♾️ CML - Continuous Machine Learning | CI/CD for ML

http://cml.dev

Apache License 2.0

4.01k stars 341 forks source link

Really deprecate dvcorg/cml-py3 #890

Closed DavidGOrtega closed 2 years ago

DavidGOrtega commented 2 years ago

[ ] mention the old image is deprecated in the readme & website?
[ ] update youtube videos?
[ ] look for popular external blogs?

At LEAST our deprecated image dvcorg/cml-py3:latest does not contain CML. The biggest problem is that we deprecated this image when many resources and tutorials still uses it.

Run cml --version
/__w/_temp/269a2252-363f-4a5e-9c83-9393827d7f47.sh: 1: /__w/_temp/269a2252-363f-4a5e-9c83-9393827d7f47.sh: cml: not found
Error: Process completed with exit code 127.

0x2b3bfa0 commented 2 years ago

In fact, cml-py3 images do include an old version of CML that predates #703 and the unified cml command; running cml-send-comment --version for example should work as expected.

0x2b3bfa0 commented 2 years ago

I wouldn't update those deprecated container images, as per https://github.com/iterative/cml/issues/383#issuecomment-870834591. Instead, this should become a documentation issue to fix all the references to deprecated container images.

0x2b3bfa0 commented 2 years ago

(Originated in Discord)

DavidGOrtega commented 2 years ago

We need to avoid this discouraging UX

0x2b3bfa0 commented 2 years ago

Action points

[x] https://github.com/iterative/dvc.org/issues/3373 [^1]
[ ] 📹 Add cards to video tutorials here with the new container image names (tracked internally)

[^1]: These are the only matches for cml-py3 in the whole https://github.com/iterative organization.

0x2b3bfa0 commented 2 years ago

🔔 @iterative/cml, worth addressing the second point?

omesser commented 2 years ago

More to update:

https://github.com/mlops-guide/mlops-guide.github.io/
more stuff from google's 1-2 first pages?
reach out and warn: https://medium.com/mlearning-ai/continuous-machine-learning-on-huggingface-transformer-with-dvc-including-weights-biases-6a909983e48e

0x2b3bfa0 commented 2 years ago

Linking to https://github.com/iterative/cml/issues/383#issuecomment-870834591 for future references. 🏺 ⛏️ 🏛️

0x2b3bfa0 commented 2 years ago

⚠️ Discord users putting the utterly deprecated cml-py3 container image on their workflows because it's being used on our example repositories, linked from the documentation. Worth a look & some improvements?

0x2b3bfa0 commented 2 years ago

@dacbd helping more users who've watched the videos and encountered this issue 🙈

dacbd commented 2 years ago

https://github.com/iterative/setup-tools

dacbd commented 2 years ago

Going to get a comment pinned on the culprit youtube videos:

Please note we have deprecated the dvcorg/cml-py3 container image.
You can get the same results with:
 - container: docker://dvcorg/cml-py3:latest
 + steps:
 +   - uses: actions/checkout@v3
 +   - uses: iterative/setup-tools@v1