search

iterative / dvc-bench

Benchmarks for DVC
http://bench.dvc.org/
Apache License 2.0
20 stars 10 forks source link

fix ci: get rid of 2.24 #412

Closed dtrifiro closed 1 year ago

dtrifiro commented 1 year ago

CI is failing because installing 2.24.0 fails

efiop commented 1 year ago

@dtrifiro Why is it failing though? Any alternatives?

skshetry commented 1 year ago

It's failing due to https://github.com/iterative/dvc/issues/8228 which was fixed in 2.25.0.

There has been a new setuptools release, which states:

Bump vendored version of :pypi:packaging to 23.0 (:pypi:pyparsing is no longer required and was removed). As a consequence, users will experience a more strict parsing of requirements. Specifications that don't comply with PEP 440 and PEP 508 will result in build errors.

dtrifiro commented 1 year ago

If you want to keep this, we can switch 2.24 with 2.25

skshetry commented 1 year ago

If we do want to keep it, a possible workaround is to constraint build dependencies by following means:

echo "setuptools<67" > constraints.txt
PIP_CONSTRAINT=constraints.txt pip install ...

The other alternatives are to patch the setup.cfg in dvc-bench after checkout, or create a new tag in dvc with the patch.

efiop commented 1 year ago

Thank you @skshetry ! 🙏

alright, let's do the simplest thing and throw it out for now.