search

iterative / dvc-exe

Private repository for building and signing dvc for windows
2 stars 1 forks source link

Use Google Cloud KMS for code signing #174

Closed 0x2b3bfa0 closed 5 months ago

0x2b3bfa0 commented 5 months ago

Minimum changes required to comply with the new DigiCert's FIPS 140-2 Level 2 or Common Criteria EAL 4+ requirements.

Closes https://github.com/iterative/dvc-exe/issues/175 for a year. 🙃

skshetry commented 5 months ago

@0x2b3bfa0, do you mind adding an upload-artifact to the workflow?

I don't have a Windows machine to test with me, but we should try installing the binary on Windows and see if we get any issues.

0x2b3bfa0 commented 5 months ago

Captura de pantalla 2024-04-03 a las 17 45 06 Captura de pantalla 2024-04-03 a las 17 46 18 Captura de pantalla 2024-04-03 a las 17 47 56

skshetry commented 5 months ago

Thank you @0x2b3bfa0. Let's merge it. 🙂