search

iterative / dvc.org

📖 DVC website and documentation
https://dvc.org
Apache License 2.0
335 stars 392 forks source link

Support "Click to expand" for images. #3131

Closed daavoo closed 6 months ago

daavoo commented 2 years ago

I think it would be nice to have a button to expand images to full size without losing the context (currently, clicking leaves you to a new tab).

Something like https://codyhouse.co/demo/expandable-image-gallery/index.html#0

jorgeorpinel commented 2 years ago

Idk. I like the new tab. I can just Ctrl + W it instead of finding some x icon to go back to the content. I guess it's a minimal difference, exp. if something like Esc can be used to close it. But in general I'm not sure I understand the value of this feature out there, except for actual galleries.

shcheklein commented 2 years ago

I think there are two things here from the product perspective - first, we could make images a bit responsive so that it's visible that they could be expanded.

Second is the UI itself on how to expand them.

On the second, we should probably do popup or a separate tab to avoid messing up with the docs layout.

jorgeorpinel commented 2 years ago

On the latter, it's a separate tab already. Simple but it does the trick, plus you get the source URL directly in the address bar.