iterative / dvc

🦉 ML Experiments and Data Management with Git
https://dvc.org
Apache License 2.0
13.38k stars 1.16k forks source link

plots: support x-dict in nested dvc.yaml #10318

Closed mattseddon closed 4 months ago

mattseddon commented 4 months ago

Thank you for the contribution - we'll try to review it as soon as possible. 🙏


This PR fixes a bug in the collection of plots definitions. The bug exists when there is a plot collected from a nested dvc.yaml that uses separate files for the x and y values.

e.g.

- Error vs max_leaf_nodes:
    template: simple
    x: 
      dvclive/plots/metrics/Max_Leaf_Nodes.tsv: Max_Leaf_Nodes
    y:
      dvclive/plots/metrics/Error.tsv: Error

in {root}/pipelines/data-increment/dvc.yaml

Previously the path to the x file was not updated to take into account the path to the dvc.yaml that it exists in.

For more context see this thread.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.69%. Comparing base (84a1750) to head (93403de).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10318 +/- ## ========================================== + Coverage 90.67% 90.69% +0.02% ========================================== Files 499 499 Lines 38459 38504 +45 Branches 5552 5555 +3 ========================================== + Hits 34871 34921 +50 + Misses 2949 2946 -3 + Partials 639 637 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.