Closed skshetry closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.22%. Comparing base (
257ea5f
) to head (d76efa6
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Will we detect when there is a fix available?
The change is intentional in pytest
, so it will likely have to be fixed in flaky
. In that case, there will be updates in the above issue.
yep, but how will we know to bump it again? will there be a dependabot PR?
I will revert this PR once the issue gets fixed.
And, yes there will be dependabot PR for newer pytest releases. But the problem is not with pytest, but with flaky.
But the problem is not with pytest, but with flaky.
yep, I got that part. Was to double check that we have a way to get back to it via some automated PR. Thanks @skshetry .
FWIW, given that flaky
hasn't seen a release since 2020 and nobody reacted to an issue asking if it was still active, this is unlikely to improve in the forseeable future. You might want to look at migrating to e.g. pytest-rerunfailures instead.
Thanks @The-Compiler for the suggestion. I have replaced flaky
with pytest-rerunfailures
in https://github.com/iterative/dvc/pull/10335. 🙂
Changes in pytest==8.1.0 breaks
flaky
plugin.See https://github.com/box/flaky/issues/198.
It's breaking the CI.