iterative / dvc

🦉 ML Experiments and Data Management with Git
https://dvc.org
Apache License 2.0
13.37k stars 1.16k forks source link

limit pytest version to <8.1 #10334

Closed skshetry closed 4 months ago

skshetry commented 4 months ago

Changes in pytest==8.1.0 breaks flaky plugin.

See https://github.com/box/flaky/issues/198.

It's breaking the CI.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.22%. Comparing base (257ea5f) to head (d76efa6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10334 +/- ## ========================================== - Coverage 90.60% 90.22% -0.39% ========================================== Files 500 500 Lines 38591 38591 Branches 5573 5564 -9 ========================================== - Hits 34965 34818 -147 - Misses 2983 3081 +98 - Partials 643 692 +49 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shcheklein commented 4 months ago

Will we detect when there is a fix available?

skshetry commented 4 months ago

The change is intentional in pytest, so it will likely have to be fixed in flaky. In that case, there will be updates in the above issue.

shcheklein commented 4 months ago

yep, but how will we know to bump it again? will there be a dependabot PR?

skshetry commented 4 months ago

I will revert this PR once the issue gets fixed.

And, yes there will be dependabot PR for newer pytest releases. But the problem is not with pytest, but with flaky.

shcheklein commented 4 months ago

But the problem is not with pytest, but with flaky.

yep, I got that part. Was to double check that we have a way to get back to it via some automated PR. Thanks @skshetry .

The-Compiler commented 4 months ago

FWIW, given that flaky hasn't seen a release since 2020 and nobody reacted to an issue asking if it was still active, this is unlikely to improve in the forseeable future. You might want to look at migrating to e.g. pytest-rerunfailures instead.

skshetry commented 4 months ago

Thanks @The-Compiler for the suggestion. I have replaced flaky with pytest-rerunfailures in https://github.com/iterative/dvc/pull/10335. 🙂