Closed skshetry closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.71%. Comparing base (
5379aa2
) to head (02453e0
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closes https://github.com/iterative/dvc/issues/10018.
We have to be careful when expanding paths. This PR fall backs to assume it as a file when either of
isdir
andfind
raises error due to some mishaps. The consequence of this assumption happens when we try to read the file. In that case, if the directory exists, and we happen to try to open it as a file, dvc will raiseIsADirectoryError
, but that is handled correctly and won't fail catastrophically like this did.This is what I get now:
The error message is not great, but at least it won't fail.