iterative / dvc

🦉 ML Experiments and Data Management with Git
https://dvc.org
Apache License 2.0
13.36k stars 1.16k forks source link

import/get: escape non-pattern LFS path parts #10416

Closed sisp closed 1 month ago

sisp commented 1 month ago

I've fixed a bug related to passing literal/non-pattern path (parts) to the LFS prefetching function from scmrepo which would interpret them as Unix filename patterns and result in incorrect path filtering results. Now, the literal/non-path path (parts) are escaped.

See https://github.com/iterative/scmrepo/pull/355#discussion_r1589847222 for the preceding discussion.

/cc @shcheklein

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.50%. Comparing base (a7c0f6e) to head (59ea6c6). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10416 +/- ## ======================================= Coverage 90.50% 90.50% ======================================= Files 502 503 +1 Lines 38982 39004 +22 Branches 5622 5626 +4 ======================================= + Hits 35279 35300 +21 - Misses 3006 3007 +1 Partials 697 697 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sisp commented 1 month ago

@shcheklein Done. WDYT?

sisp commented 1 month ago

Thanks for your feedback, @shcheklein! Would you mind another review? :pray:

shcheklein commented 1 month ago

thanks @sisp !